-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Pandas 2 #673
Conversation
Flix6x
commented
May 8, 2023
•
edited
edited
- Requires Support Pandas 2 SeitaBV/timely-beliefs#131
- Requires Support Pandas 2 SeitaBV/timetomodel#28
- Figure out why linear_optimization.py now needs inclusive="both" rather than inclusive="left" -> BUG: Timedelta created by to_timedelta does not add correctly to datetime in Pandas 2 pandas-dev/pandas#53643
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we still pin to 1.5.3 right? (requirements/app.txt says: pandas==1.5.3`)
- Have you run the tests with pandas 2.0 installed? (I'd be interested in the difference in timing btw :)
- Why not move up the pin now? It's by now mostly for developers and the Docker image. If you opt to wait, it means you want to gather experience?
I want to, but I'm struggling to do this successfully with any of our |
# Conflicts: # documentation/changelog.rst
Yes, that would update many others, as well. Best to update all new pins right after the next release. But maybe you can pip-install pandas 2, to see if our tests pass (and are faster) |
Signed-off-by: F.N. Claessen <felix@seita.nl>
Thanks. The results:
I did notice a small fix was needed with some of the new reporter functionality. So I pushed one more commit. |
Signed-off-by: F.N. Claessen <felix@seita.nl>
Ah, no big speed gain here :) |